Re: [PATCH 7/8] staging: wilc1000: replace udelay with usleep_range
From: Greg KH <gregkh@linuxfoundation.org>
Date: 2018-08-02 09:24:09
On Sun, Jul 29, 2018 at 11:36:56AM +0530, Ajay Singh wrote:
quoted hunk ↗ jump to hunk
Cleanup patch to avoid the below checkpatch reported issue. "usleep_range is preferred over udelay; see Documentation/timers/timers-howto.txt". Signed-off-by: Ajay Singh <ajay.kathat@microchip.com> --- drivers/staging/wilc1000/wilc_wlan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/drivers/staging/wilc1000/wilc_wlan.c b/drivers/staging/wilc1000/wilc_wlan.c index 6bac3f7..655952a 100644 --- a/drivers/staging/wilc1000/wilc_wlan.c +++ b/drivers/staging/wilc1000/wilc_wlan.c@@ -425,7 +425,7 @@ void chip_wakeup(struct wilc *wilc) } while (wilc_get_chipid(wilc, true) == 0); } else if ((wilc->io_type & 0x1) == HIF_SDIO) { wilc->hif_func->hif_write_reg(wilc, 0xfa, 1); - udelay(200); + usleep_range(200, 201);
Hah, that's funny. No, do it right, don't try to game checkpatch here. greg k-h