Re: [PATCH 8/8] staging: wilc1000: added parentheses in macro to avoid checkpatch issue
From: Ajay Singh <ajay.kathat@microchip.com>
Date: 2018-08-02 10:16:59
From: Ajay Singh <ajay.kathat@microchip.com>
Date: 2018-08-02 10:16:59
Hi Greg, On Thu, 2 Aug 2018 09:34:54 +0200 Greg KH [off-list ref] wrote:
On Sun, Jul 29, 2018 at 11:36:57AM +0530, Ajay Singh wrote:quoted
Cleanup patch to fix below checkpatch reported issue: -#define ISWILC1000(id) ((id & 0xfffff000) == 0x100000 ? 1 : 0) +#define ISWILC1000(id) (((id) & 0xfffff000) == 0x100000 ? 1 : 0)Even better, make this an inline function that returns a boolean to avoid any potental problems.
Sure, I will make these changes and submit new patch. Regards Ajay