Re: [PATCH net-next v2 2/2] dt: bindings: add new dt entries for brcmfmac
flat view
From: Arend van Spriel <arend.vanspriel@broadcom.com>
Date: 2018-03-19 09:32:13
Also in:
linux-devicetree, lkml, netdev
On 3/19/2018 2:40 AM, Alexey Roslyakov wrote:
quoted hunk ↗ jump to hunk
In case if the host has higher align requirements for SG items, allow setting device-specific aligns for scatterlist items. Signed-off-by: Alexey Roslyakov <redacted> --- Documentation/devicetree/bindings/net/wireless/brcm,bcm43xx-fmac.txt | 5 +++++ 1 file changed, 5 insertions(+)diff --git a/Documentation/devicetree/bindings/net/wireless/brcm,bcm43xx-fmac.txt b/Documentation/devicetree/bindings/net/wireless/brcm,bcm43xx-fmac.txt index 86602f264dce..187b8c1b52a7 100644 --- a/Documentation/devicetree/bindings/net/wireless/brcm,bcm43xx-fmac.txt +++ b/Documentation/devicetree/bindings/net/wireless/brcm,bcm43xx-fmac.txt@@ -17,6 +17,11 @@ Optional properties: When not specified the device will use in-band SDIO interrupts. - interrupt-names : name of the out-of-band interrupt, which must be set to "host-wake". + - brcm,broken-sg-support : boolean flag to indicate that the SDIO host + controller has higher align requirement than 32 bytes for each + scatterlist item. + - brcm,sd-head-align : alignment requirement for start of data buffer. + - brcm,sd-sgentry-align : length alignment requirement for each sg entry.
Hi Alexey, Thanks for the patch. However, the problem with these is that they are characterizing the host controller and not the wireless device. So from device tree perspective , which is to describe the hardware, these properties should be SDIO host controller properties. Also I am not sure if the broken-sg-support is still needed. We added that for omap_hsmmc, but that has since changed to scatter-gather emulation so it might not be needed anymore. Regards, Arend