Re: [PATCH 02/34] brcmfmac: Register sizes on hardware are not dependent on compiler types
From: Arend van Spriel <arend.vanspriel@broadcom.com>
Date: 2017-08-07 11:25:34
From: Arend van Spriel <arend.vanspriel@broadcom.com>
Date: 2017-08-07 11:25:34
On 26-07-17 22:25, Ian Molton wrote:
The 4 IO functions in this patch are incorrect as they use compiler types to determine how many bytes to send to the hardware.
I see no incorrectness here. It is validating the regsz value and those compiler types are pretty well defined I would say. Anyway, I find the use of sizeof() here pretty useless so thanks for the change. Reviewed-by: Arend van Spriel <arend.vanspriel@broadcom.com>
Signed-off-by: Ian Molton <redacted> --- .../wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-)