Thread (84 messages) 84 messages, 4 authors, 2017-08-30

Re: [PATCH 11/34] brcmfmac: Split brcmf_sdiod_buffrw function up.

From: Ian Molton <hidden>
Date: 2017-08-19 21:41:46

On 07/08/17 12:26, Arend van Spriel wrote:
quoted
+        err = brcmf_sdiod_buff_write(sdiodev, SDIO_FUNC_2, addr, mypkt);

      brcmu_pkt_buf_free_skb(mypkt);
+
You are keen on sprinkling whitespace here and there. Could you please
use separate patches for that as much as possible. Not sure why you
added this one...
quoted
      return err;
...and kept this one.
quoted
  }
Good catch. There's a couple of others - I'll break them out. That
latter one is clearly an error on my part.

-Ian
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help