Thread (18 messages) 18 messages, 4 authors, 2017-08-09

Re: [PATCH v4 10/10] wil6210: make debugfs compilation optional

From: Kalle Valo <hidden>
Date: 2017-08-08 18:45:38

Lior David [off-list ref] writes:
On 8/8/2017 2:03 PM, Kalle Valo wrote:
quoted
Maya Erez [off-list ref] writes:
=20
quoted
From: Gidon Studinski <redacted>

Since debugfs is a kernel configuration option, enable the driver to
compile without debugfs.

Signed-off-by: Gidon Studinski <redacted>
Signed-off-by: Maya Erez <redacted>
[...]
quoted
quoted
+#if defined(CONFIG_DEBUG_FS)
 int wil6210_debugfs_init(struct wil6210_priv *wil);
 void wil6210_debugfs_remove(struct wil6210_priv *wil);
+#else
+static inline int wil6210_debugfs_init(struct wil6210_priv *wil) { ret=
urn 0; }
quoted
quoted
+static inline void wil6210_debugfs_remove(struct wil6210_priv *wil) {}
+#endif
=20
I was thinking more that should we have CONFIG_WIL6210_DEBUGFS, just
like we have CONFIG_ATH10K_DEBUGFS and CONFIG_ATH9K_DEBUGFS? This way it
can be controlled per driver if debugfs interface is available or not.
=20
Hi Kalle, I am answering instead of Maya, she is currently on holiday.
We will consider this and resend the patch.
Ok, no rush.
Is it possible to apply the other patches in the v4 series except this on=
e and
patch #2 (the scan timeout module parameter)?
I was actually planning to do exactly that. I was just waiting for
kbuild bot results because I had to fix a trivial conflict after
removing patch 2.

--=20
Kalle Valo=
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help