Thread (14 messages) 14 messages, 3 authors, 2017-03-31

Re: [RFC v2 1/2] cfg80211: support 4-way handshake offloading for WPA/WPA2-PSK

From: Johannes Berg <johannes@sipsolutions.net>
Date: 2017-02-21 14:46:13

While the existing WPA2-PSK cases all use 32 octet PMK, there are
also
48 octet PMKs in use with EAP (Suite B 192-bit level and FILS with
SHA384). Patch 2/2 seemed to look at the PMK length as well.. Should
the same be done already with 1/2 so that the PSK case is separately
validating exact match with 32 octets in length for PMK = PSK while
the other cases allow longer PMK as well?

I never remember how the attr policy .len works, so that may already
be the implicit behavior here, but it would be clearer to be more
explicit about the possible lengths of the WLAN_ATTR_PMK and not
assume that WLAN_PMK_LEN definition is the only possible option.
The .len verifies that it's at least that long. We're thus ignoring
additional bytes in the PSK case if they're present, which I suppose we
should fix by checking the exact length in the code separately.

johannes
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help