Re: [RFC v2 1/2] cfg80211: support 4-way handshake offloading for WPA/WPA2-PSK
From: Arend Van Spriel <arend.vanspriel@broadcom.com>
Date: 2017-02-23 10:26:08
On 21-2-2017 15:47, Johannes Berg wrote:
quoted
The .len verifies that it's at least that long. We're thus ignoring additional bytes in the PSK case if they're present, which I suppose we should fix by checking the exact length in the code separately.
libnl seems to have the notion of min_len and max_len in its policy definition, but the kernel does not so .len is actually min_len indeed.
quoted hunk ↗ jump to hunk
IOW, I'll add this:--- a/net/wireless/nl80211.c +++ b/net/wireless/nl80211.c@@ -8044,6 +8044,8 @@ static int nl80211_crypto_settings(struct cfg80211_registered_device *rdev, if (!wiphy_ext_feature_isset(&rdev->wiphy, NL80211_EXT_FEATURE_4WAY_HANDSHAKE_STA_PSK)) return -EINVAL; + if (nla_len(info->attrs[NL80211_ATTR_PMK]) != WLAN_PMK_LEN) + return -EINVAL;
Makes sense. Regards, Arend
settings->psk = nla_data(info->attrs[NL80211_ATTR_PMK]); } johannes