Re: [RFC] ath10k: silence firmware file probing warnings
From: Felix Fietkau <nbd@nbd.name>
Date: 2016-08-02 11:52:46
On 2016-08-02 13:18, Valo, Kalle wrote:
Michal Kazior [off-list ref] writes:quoted
Firmware files are versioned to prevent older driver instances to load unsupported firmware blobs. This is reflected with a fallback logic which attempts to load several firmware files. This however produced a lot of unnecessary warnings sometimes confusing users and leading them to rename firmware files making things even more confusing. Hence use request_firmware_direct() which does not produce extra warnings. This shouldn't really break anything because most modern systems don't rely on udev/hotplug helpers to load firmware files anymore. Signed-off-by: Michal Kazior <redacted>Nice. These "firmware not found" messages have been confusing ath10k users for ages and should be properly fixed. I hope we find a solution. But I talked with Felix about this and he made a good point about board and calibration files. Calibration files might be created runtime, for example retrieved from NAND etc, and this might break the use case when ath10k is statically linked to kernel. Is the combination used in real life and should we care, that I do not know, but I'm worried of possible regressions. I guess LEDE/openwrt always loads ath10k as a module and after the calibration file is created?
ath10k is always loaded as a module, and the calibration file is created by a script that's triggered by the firmware uevent. - Felix