Thread (34 messages) 34 messages, 8 authors, 2016-07-28

Re: staging: wilc1000: Reduce scope for a few variables in mac_ioctl()

From: SF Markus Elfring <hidden>
Date: 2016-07-28 16:01:00
Also in: kernel-janitors, lkml

Which circumstances do "not any sense at all" imply? 
Should the expression 'strlen("RSSI")' be passed for the parameter 'length' instead?

I suggest to fix this since it is indeed a bug,
We can agree that this function implementation was broken for a while there.

instead of doing "micro optimizations" - which is the last thing that code in the staging area 
needs (as IIRC you have already been told by others, including the staging maintainer).
The acceptance might grow a bit more for such software fine-tuning
(like refactoring around variable usage).

Regards,
Markus
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help