Re: [PATCH 3/3] staging: wilc1000: Reduce scope for a few variables in mac_ioctl()

(off-list ancestor, not in this archive)
[PATCH 0/2] staging: wilc1000: Deletion of two unnecessary checks · SF Markus Elfring <hidden> · 2015-06-27
[PATCH 1/2] staging: wilc1000: Delete unnecessary checks before two function calls · SF Markus Elfring <hidden> · 2015-06-27
Re: [PATCH 1/2] staging: wilc1000: Delete unnecessary checks before two function calls · Greg Kroah-Hartman <gregkh@linuxfoundation.org> · 2015-07-07
Re: Clarification for the use of additional fields in the message body · SF Markus Elfring <hidden> · 2015-07-07
Re: Clarification for the use of additional fields in the message body · Frans Klaver <hidden> · 2015-07-07
Re: Clarification for the use of additional fields in the message body · SF Markus Elfring <hidden> · 2015-07-07
Re: Clarification for the use of additional fields in the message body · Frans Klaver <hidden> · 2015-07-07
Re: Clarification for the use of additional fields in the message body · SF Markus Elfring <hidden> · 2015-07-07
Re: Clarification for the use of additional fields in the message body · Frans Klaver <hidden> · 2015-07-07
Re: Clarification for the use of additional fields in the message body · SF Markus Elfring <hidden> · 2015-07-07
Re: Clarification for the use of additional fields in the message body · Julian Calaby <hidden> · 2015-07-07
Re: Clarification for the use of additional fields in the message body · SF Markus Elfring <hidden> · 2015-07-08
Re: Clarification for the use of additional fields in the message body · Julian Calaby <hidden> · 2015-07-08
Re: Clarification for the use of additional fields in the message body · SF Markus Elfring <hidden> · 2015-07-08
Re: Clarification for the use of additional fields in the message body · Julian Calaby <hidden> · 2015-07-08
Re: Clarification for the use of additional fields in the message body · SF Markus Elfring <hidden> · 2015-07-08
Re: Clarification for the use of additional fields in the message body · Julian Calaby <hidden> · 2015-07-08
Re: Clarification for the use of additional fields in the message body · "Theodore Ts'o" <tytso@mit.edu> · 2015-07-08
Re: Clarification for the use of additional fields in the message body · SF Markus Elfring <hidden> · 2015-07-08
Re: Clarification for the use of additional fields in the message body · "Theodore Ts'o" <tytso@mit.edu> · 2015-07-09
[PATCH 2/2] staging: wilc1000: One function call less in mac_ioctl() after error detection · SF Markus Elfring <hidden> · 2015-06-27
Re: [PATCH 2/2] staging: wilc1000: One function call less in mac_ioctl() after error detection · Julia Lawall <hidden> · 2015-06-27
Re: [PATCH 2/2] staging: wilc1000: One function call less in mac_ioctl() after error detection · Greg Kroah-Hartman <gregkh@linuxfoundation.org> · 2015-07-07
Re: staging: wilc1000: One function call less in mac_ioctl() after error detection · SF Markus Elfring <hidden> · 2015-07-08
[PATCH 0/3] staging: wilc1000: Fine-tuning for two function implementations · SF Markus Elfring <hidden> · 2016-07-24
[PATCH 1/3] staging: wilc1000: Delete an unnecessary check before the function call "release_firmware" · SF Markus Elfring <hidden> · 2016-07-24
[PATCH 2/3] staging: wilc1000: One function call less in mac_ioctl() after error detection · SF Markus Elfring <hidden> · 2016-07-24
Re: [PATCH 2/3] staging: wilc1000: One function call less in mac_ioctl() after error detection · Julian Calaby <hidden> · 2016-07-28
[PATCH 3/3] staging: wilc1000: Reduce scope for a few variables in mac_ioctl() · SF Markus Elfring <hidden> · 2016-07-24
Re: [PATCH 3/3] staging: wilc1000: Reduce scope for a few variables in mac_ioctl() · Lino Sanfilippo <LinoSanfilippo@gmx.de> · 2016-07-25
Re: [PATCH 3/3] staging: wilc1000: Reduce scope for a few variables in mac_ioctl() · walter harms <hidden> · 2016-07-25
Re: staging: wilc1000: Reduce scope for a few variables in mac_ioctl() · SF Markus Elfring <hidden> · 2016-07-26
Aw: Re: staging: wilc1000: Reduce scope for a few variables in mac_ioctl() · "Lino Sanfilippo" <LinoSanfilippo@gmx.de> · 2016-07-28
Re: staging: wilc1000: Reduce scope for a few variables in mac_ioctl() · SF Markus Elfring <hidden> · 2016-07-28

From: walter harms <hidden>
Date: 2016-07-25 19:32:16
Also in: kernel-janitors, lkml


Am 25.07.2016 21:17, schrieb Lino Sanfilippo:

quoted

 
-			if (strncasecmp(buff, "RSSI", length) == 0) {
+			if (strncasecmp(buff, "RSSI", 0) == 0) {
+				s8 rssi;
+

Um, please think a second about if it makes any sense at all to compare 
zero chars of two strings.

Lino

also:
the switch has only one case and default.

re,
 wh

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help