Thread (139 messages) 139 messages, 3 authors, 2016-03-11

Re: [PATCH 107/113] rtl8xxxu: Use define for REG_PWR_DATA bits

From: Jes Sorensen <hidden>
Date: 2016-03-10 14:55:07

Kalle Valo [off-list ref] writes:
Jes.Sorensen@redhat.com writes:
quoted
From: Jes Sorensen <redacted>

Use the bit define rather than hard code the value for REG_PWR_DATA bits.

Signed-off-by: Jes Sorensen <redacted>
[...]
quoted
--- a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_regs.h
+++ b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_regs.h
@@ -135,7 +135,7 @@
 #define  EFUSE_ACCESS_DISABLE		0x00	/* RTL8723 only */
 
 #define REG_PWR_DATA			0x0038
-#define PWR_DATA_EEPRPAD_RFE_CTRL_EN	BIT(11)
+#define  PWR_DATA_EEPRPAD_RFE_CTRL_EN	BIT(11)
Again the two spaces. Is your editor adding them automatically or what?
As in the previous email, this is for bit defines, matching the
register. The above just made it consistent with the rest of the code.

Jes
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help