Thread (41 messages) 41 messages, 4 authors, 2016-03-07

Re: [PATCH v2 07/11] ath10k: implement wake_tx_queue

From: Michal Kazior <hidden>
Date: 2016-03-07 06:04:17

On 6 March 2016 at 15:27, Valo, Kalle [off-list ref] wrote:
Michal Kazior [off-list ref] writes:
quoted
This implements very basic support for software
queueing. It also contains some knobs that will be
patched later.

Signed-off-by: Michal Kazior <redacted>
Oddly this patch introduces a new warning:

drivers/net/wireless/ath/ath10k/mac.c: In function ath10k_mac_op_tx:
drivers/net/wireless/ath/ath10k/mac.c:3949:29: warning: is_mgmt may be used uninitialized in this function [-Wuninitialized]

But I think that's just a false warning, most likely because my gcc is
ancient. Do you agree?
Yes, I agree. It must be the fact is_mgmt is set/used across two
is_htt condition branches.

gcc (Ubuntu/Linaro 4.6.3-1ubuntu5) 4.6.3
gcc (Debian 4.9.2-10) 4.9.2 -- no warning for me.


Michał
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help