Thread (41 messages) 41 messages, 4 authors, 2016-03-07

Re: [PATCH 13/13] ath10k: implement push-pull tx

From: Peter Oh <hidden>
Date: 2016-01-26 19:05:47

On 01/26/2016 02:28 AM, Michal Kazior wrote:
On 22 January 2016 at 08:47, Michal Kazior [off-list ref] wrote:
quoted
On 21 January 2016 at 18:40, Peter Oh [off-list ref] wrote:
quoted
On 01/21/2016 05:46 AM, Michal Kazior wrote:
[...]
quoted
quoted
quoted
   -     /* TODO: apply configuration */
+       rcu_read_unlock();
+
+       spin_lock_bh(&ar->htt.tx_lock);
+       ath10k_mac_tx_lock(ar, ATH10K_TX_PAUSE_Q_FLUSH_PENDING);
+       spin_unlock_bh(&ar->htt.tx_lock);
+
Isn't it proved it break Mesh from working?
Yes, good point. I'm still working on this - I should've mentioned
that in the cover letter.

Nonetheless I wanted to get the review process going for this patchset.

I'll address the mesh problem in v2.
For the record - the problem turned out to be a bug in mac80211 mesh
fwding, see:

   https://patchwork.kernel.org/patch/8108711/
I've verified that the patch fixed the mesh issue.
Thank you Michal.

Michał
  
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help