On Sat, 2016-01-30 at 10:17 +1100, Julian Calaby wrote:

On Sat, Jan 30, 2016 at 5:00 AM, Jes Sorensen [off-list ref] wrote:

quoted

Bhaktipriya Shridhar [off-list ref] writes:

quoted

This patch fixes checkpatch.pl warning in rtw_mlme_ext.c file.
WARNING: void function return statements are not generally useful

[]

quoted

quoted

diff --git a/drivers/staging/rtl8723au/core/rtw_mlme_ext.c b/drivers/staging/rtl8723au/core/rtw_mlme_ext.c

[]

quoted

quoted

@@ -2657,7 +2657,6 @@ static void issue_probersp(struct rtw_adapter *padapter, unsigned char *da)

      dump_mgntframe23a(padapter, pmgntframe);

-     return;
 }

If you insist on pushing this rather unncessary change, please do it
properly, and remove the blank line before the return statement as well.

As Jes said, you need to remove the blank lines before the returns
too. checkpatch should have picked this up, you did run the patch
through checkpatch before you sent it, right?

checkpatch doesn't pick this up.

If you'd like to make it do so, you're welcome to try
but it's likely a bit more complicated than it appears.