Re: [PATCH] brcmfmac: sdio: Increase the default timeouts a bit
From: Arend van Spriel <hidden>
Date: 2016-01-26 06:29:54
Also in:
linux-rockchip, lkml, netdev
From: Arend van Spriel <hidden>
Date: 2016-01-26 06:29:54
Also in:
linux-rockchip, lkml, netdev
On 26-01-16 00:41, Julian Calaby wrote:
Hi Arend, On Tue, Jan 26, 2016 at 2:39 AM, Arend van Spriel [off-list ref] wrote:quoted
On 25-01-16 12:06, Julian Calaby wrote:quoted
Hi Sjoerd, On Mon, Jan 25, 2016 at 9:47 PM, Sjoerd Simons [off-list ref] wrote:quoted
On a Radxa Rock2 board with a Ampak AP6335 (Broadcom 4339 core) it seems the card responds very quickly most of the time, unfortunately during initialisation it sometimes seems to take just a bit over 2 seconds to respond. This results intialization failing with message like: brcmf_c_preinit_dcmds: Retreiving cur_etheraddr failed, -52 brcmf_bus_start: failed: -52 brcmf_sdio_firmware_callback: dongle is not responding Increasing the timeout to allow for a bit more headroom allows the card to initialize reliably. A quick search online after diagnosing/fixing this showed that Google has a similar patch in their ChromeOS tree, so this doesn't seem specific to the board I'm using. Signed-off-by: Sjoerd Simons <redacted>Looks sane to me. Reviewed-by: Julian Calaby <redacted>Not really a cleanup patch :-p , but thanks for the review.I'm trying to review any "small" patch from (relatively) new people.
And it is surely appreciated. Just read your reply in "cleanup patch pile" thread and felt I had to make the stupid remark with just fun intended. Regards, Arend