Thread (23 messages) 23 messages, 6 authors, 2016-01-19

Re: rsi: Delete unnecessary variable initialisations in rsi_send_mgmt_pkt()

From: SF Markus Elfring <hidden>
Date: 2016-01-05 08:30:21
Also in: kernel-janitors, lkml, netdev

That said, if you figure out some change that produces significant
reductions in code or binary size on multiple architectures without
making things more complicated, less readable or making the code or
binary size larger, then by all means propose it.
Are you looking also for "a proof" that such changes are worthwhile?

"This makes things smaller" carries much more weight than
"I think this is better".
Can the discussed implementation of a function like "rsi_send_mgmt_pkt"
become a bit smaller by the deletion of extra variable initialisations

Almost all of the changes you've proposed that have seen any
discussion whatsoever fall into the latter category.
Thanks for your interesting feedback.

Can a further constructive dialogue evolve from the presented information?

Regards,
Markus
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help