Thread (23 messages) 23 messages, 6 authors, 2016-01-19

Re: [PATCH 1/3] rsi: Delete unnecessary variable initialisations in rsi_send_mgmt_pkt()

From: SF Markus Elfring <hidden>
Date: 2016-01-04 10:44:30
Also in: kernel-janitors, lkml, netdev

Possibly related (same subject, not in this thread)

These patches are labour intensive to review because you can't just do
it in the email client.
Thanks for your general interest.

Also you were not able to review it properly yourself and introduced
a bug.
I admit that it can happen during my software development that I overlook
implementation details somehow.

I am often remove initializers but it's normally because I am changing
something else which makes it worthwhile.
It is nice to hear that you are also occasionally looking for similar
update candidates.

This patch is the correct thing but it's not "worthwhile".
I find this view interesting.

Please stop sending cleanup patches, Markus.  Just send fixes.
How often will source code clean-up fix something?


May I resend a consistent patch series for the source file
"drivers/net/wireless/rsi/rsi_91x_pkt.c" in the near future?

Regards,
Markus
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help