Thread (10 messages) 10 messages, 3 authors, 2015-09-30

Re: [PATCH 1/2] drivers: staging: wilc1000: Replace message queue with standard Linux lists

From: Chandra Gorentla <hidden>
Date: 2015-09-30 12:30:08
Also in: lkml

On Tue, Sep 29, 2015 at 02:44:02AM +0200, Greg KH wrote:
On Mon, Sep 28, 2015 at 11:43:55PM +0530, Chandra S Gorentla wrote:
quoted
 - The message queue is replaced with standard Linux linked list
 - kmem_cache is used for list members
Why?
The list entires are of fixed type and repeatedly allocated and deallocated
for messages.
quoted
 - A check for return value of receive method is added
 - GFP_ATOMIC is changed to GFP_KERNEL
Why?  Are you sure that is safe?
The allocations are moved out of 'spin_lock_irqsave' and
'spin_unlock_irqrestore'.  Hence they are safe.
quoted
 - A few other related minor changes
Be specific please.
OK.  I will try to send seperate patches.
thanks,

greg k-h
Thank you,
chandra
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help