Thread (10 messages) 10 messages, 3 authors, 2015-09-30

Re: [PATCH 1/2] drivers: staging: wilc1000: Replace message queue with standard Linux lists

From: Dan Carpenter <hidden>
Date: 2015-09-29 02:32:15
Also in: lkml

On Mon, Sep 28, 2015 at 11:43:55PM +0530, Chandra S Gorentla wrote:
 - The message queue is replaced with standard Linux linked list
 - kmem_cache is used for list members
 - A check for return value of receive method is added
 - GFP_ATOMIC is changed to GFP_KERNEL
 - A few other related minor changes
These should be listed and explained.
 
 	while (1) {
-		wilc_mq_recv(&gMsgQHostIF, &msg, sizeof(struct host_if_msg), &u32Ret);
+		ret = wilc_mq_recv(&gMsgQHostIF, &msg,
+					sizeof(struct host_if_msg), &u32Ret);
+		if (ret)
+			continue;
+
I asked before if this was a forever loop and never got a response.
Also what does this have to do with list macros?

regards,
dan carpenter
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help