On Mon, Sep 21, 2015 at 09:05:54AM +0200, Michal Kazior wrote:

On 16 September 2015 at 09:49, Rajkumar Manoharan
[off-list ref] wrote:

quoted

ldpc is not configured for fixed rates. This blocks auto rate vs fixed
rate performance comparison. Since firmware is considering ldpc vdev
param for fixed rate selection, it has to be configured to enable ldpc
for fixed rates.

Signed-off-by: Rajkumar Manoharan <redacted>
---

[...]

quoted

@@ -6041,6 +6049,7 @@ static int ath10k_mac_op_set_bitrate_mask(struct ieee80211_hw *hw,
        band = def.chan->band;
        ht_mcs_mask = mask->control[band].ht_mcs;
        vht_mcs_mask = mask->control[band].vht_mcs;
+       ldpc = !!(ar->ht_cap_info & WMI_HT_CAP_LDPC);

Is still really correct? LDPC must be supported on the Rx side of
destination stations hence I would assume you need to check whether
all stations associated are LDPC capable before enabling it (e.g. via
ieee80211_iterate_stations_atomic).

I already check with firmware on this regard. Below is the clarification
got from fw team. So no need to go through sta_iter.

"3) how does fixed rate work for non-LDPC clients (ex. legacy clients),
if LDPC support is enabled for the given vdev?
The rates are selected by ANDng the vdev_rates and client rates. If client does not
support LDPC and LDPC is enabled in vdev then, LDPC will not be used."

-Rajkumar