Re: [PATCH] ath10k: fix ldpc param for fixed rate
From: Michal Kazior <hidden>
Date: 2015-09-21 07:05:55
On 16 September 2015 at 09:49, Rajkumar Manoharan [off-list ref] wrote:
ldpc is not configured for fixed rates. This blocks auto rate vs fixed rate performance comparison. Since firmware is considering ldpc vdev param for fixed rate selection, it has to be configured to enable ldpc for fixed rates. Signed-off-by: Rajkumar Manoharan <redacted> ---
[...]
quoted hunk ↗ jump to hunk
@@ -6041,6 +6049,7 @@ static int ath10k_mac_op_set_bitrate_mask(struct ieee80211_hw *hw, band = def.chan->band; ht_mcs_mask = mask->control[band].ht_mcs; vht_mcs_mask = mask->control[band].vht_mcs; + ldpc = !!(ar->ht_cap_info & WMI_HT_CAP_LDPC);
Is still really correct? LDPC must be supported on the Rx side of destination stations hence I would assume you need to check whether all stations associated are LDPC capable before enabling it (e.g. via ieee80211_iterate_stations_atomic). Michał