On Tue, Aug 28, 2012 at 03:52:08PM +0300, Daniel Golle wrote:

Hi Stanislaw,

On 28/08/12 15:42, Stanislaw Gruszka wrote:

quoted

Thanks. Could you also provide information what was the source
(registers programming) you based when writing this patch?

The vendor-driver Allnet got for that board (which is not publicly available and
we can't release its source)

quoted

quoted

+	if (rt2x00_rt(rt2x00dev, RT3352)) {
+		rt2800_bbp_write(rt2x00dev, 27, 0x0);
+		rt2800_bbp_write(rt2x00dev, 62, 0x26 + rt2x00dev->lna_gain);
+		rt2800_bbp_write(rt2x00dev, 27, 0x20);
+		rt2800_bbp_write(rt2x00dev, 62, 0x26 + rt2x00dev->lna_gain);

Writes two times to the same registers are intended?

Yes, as this is how it is done in the vendor driver, to me it looks like
register 27 acts as a switch selecting the destination for the value written to
register 62 or something like that.

Daniel,

Could you perhaps repost a new patch with a "finalized" commit message
that covers the original patch and addresses Stanislaw's concerns
in a single, neat message?

Thanks!

John
-- 
John W. Linville		Someday the world will need a hero, and you
linville@tuxdriver.com			might be all we have.  Be ready.