Re: [PATCH]: With no attatchment NOT SPAM, a REWRITE
From: Julian Calaby <hidden>
Date: 2012-08-06 01:52:59
Also in:
lkml
Hi Christopher, On Mon, Aug 6, 2012 at 11:01 AM, Christopher Sacchi [off-list ref] wrote:
Hey guys, this should work now.
I see the changes you made, however you're not going to get them accepted in this format. See Documentation/SubmittingPatches Online here: https://git.kernel.org/?p=linux/kernel/git/linville/wireless-testing.git;a=blob;f=Documentation/SubmittingPatches;h=c379a2a6949f1c1cac04fb6f185c633512f37061;hb=HEAD
quoted hunk ↗ jump to hunk
----- main.c 2012-07-21 20:58:29.000000000 +0000 +++ mainnew.c 2012-08-05 20:00:37.000000000 +0000@@ -32,7 +32,7 @@ #include "led.h" #include "cfg.h" #include "debugfs.h" -
Why are you removing the blank line - it's required as part of the kernel coding style.
+#include "net/rfkill/rfkill.h"
You don't seem to actually be adding any code that uses anything in this header and don't explain why it's needed.
quoted hunk ↗ jump to hunk
static struct lock_class_key ieee80211_rx_skb_queue_class; void ieee80211_configure_filter(struct ieee80211_local *local)@@ -183,6 +183,7 @@ * */ /* WARN_ON(ret); */ + WARN_ON(1)
What bug is this fixing? What problem is this solving? Thanks, -- Julian Calaby Email: julian.calaby@gmail.com Profile: http://www.google.com/profiles/julian.calaby/ .Plan: http://sites.google.com/site/juliancalaby/