Re: [RFC][PATCHv2 2/3] lib: printf: append support of '%*p[Mm][FR]'

From
Joe Perches <joe@perches.com>
Date
2012-07-03 15:33:53
Also in
lkml
Reply to
Andy Shevchenko, 2012-07-03
On Tue, 2012-07-03 at 13:06 +0300, Andy Shevchenko wrote:
There are many places in the kernel where the drivers print small buffers as a
hex string. This patch adds a support of the variable width buffer to print it
as a hex string with a delimiter. The idea came from Pavel Roskin here:
http://www.digipedia.pl/usenet/thread/18835/17449/

Sample output of
	pr_info("buf[%d:%d] %*pM\n", from, len, len, &buf[from]);
could be look like this:
	[ 0.726130] buf[51:8] e8:16:b6:ef:e3:74:45:6e
	[ 0.750736] buf[59:15] 31:81:b8:3f:35:49:06:ae:df:32:06:05:4a:af:55
	[ 0.757602] buf[17:5] ac:16:d5:2c:ef
Hi Andy.
quoted hunk ↗ jump to hunk
diff --git a/lib/vsprintf.c b/lib/vsprintf.c
[]
quoted hunk ↗ jump to hunk
@@ -655,12 +655,13 @@ char *resource_string(char *buf, char *end, struct resource *res,
[]
+char *hex_string(char *buf, char *end, u8 *addr, struct printf_spec spec,
+		 const char *fmt)
[]
quoted hunk ↗ jump to hunk
@@ -678,18 +679,31 @@ char *mac_address_string(char *buf, char *end, u8 *addr,
[]
+	while (i < len) {
Oh good, a while loop, thanks.

[]
quoted hunk ↗ jump to hunk
@@ -947,6 +961,9 @@ int kptr_restrict __read_mostly;
  * - 'MF' For a 6-byte MAC FDDI address, it prints the address
  *       with a dash-separated hex notation
  * - '[mM]R For a 6-byte MAC address, Reverse order (Bluetooth)
+ *       Optional usage is %*p[Mn][FR] with variable length to print. It
+ *       supports up to 64 bytes of the input. Consider to use print_hex_dump()
+ *       for the larger input.
It might be more sensible to use new, distinct
"%*pH" and "%*ph" functions and not touch the
mac address function at all.  Will anyone ever
really want to emit the buffer in reverse?
I don't think so.

Perhaps when using a hex_string_buffer func the
separator should be a space/no-space with %*pHh.

You could extend the max to 128 or larger now.

Thread (31 messages) 31 messages, 9 authors, last reply 2012-09-11
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help