Thread (31 messages) 31 messages, 9 authors, 2012-09-11

Re: [PATCH] wireless: at76c50x: fix multithread access to hex2str

From: Pavel Roskin <hidden>
Date: 2011-09-30 15:53:41

On Thu, 29 Sep 2011 13:46:55 +0300
Andy Shevchenko [off-list ref] wrote:
On Wed, 2011-09-28 at 17:19 -0400, Pavel Roskin wrote: 
quoted
Or maybe you could develop an extension for printk() format that
would dump strings of the given length?  Something like %pM, but
with an extra argument (and make sure it would not trigger a gcc
warning). This way, everybody would benefit.
I don't think it would be a noticeable benefit. On the other hand
vsnprintf() is hugely overloaded by many "extensions" to the C99
variant.
I looked at the code, and it seems very little is needed to support
"%*pM"
quoted
Please rethink whether it's helpful to send such "fixes" for old and
little maintained drivers.
Last copyright is 2010, TODO list actually suggests to remove hex2str
at all.
I don't know where it's written, but I think it's a good idea,
especially if there is a better alternative available for all drivers.

-- 
Regards,
Pavel Roskin
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help