Re: pull request: wireless 2012-02-20

From
Zefir Kurtisi <hidden>
Date
2012-02-22 10:20:39
Also in
lkml, netdev
Reply to
David Miller, 2012-02-21
On 02/21/2012 09:40 PM, David Miller wrote:
From: Andrei Emeltchenko <redacted>
Date: Tue, 21 Feb 2012 22:38:16 +0200
quoted
Hi David,

On Tue, Feb 21, 2012 at 9:44 PM, David Miller [off-list ref] wrote:
quoted
From: "John W. Linville" <redacted>
Date: Tue, 21 Feb 2012 10:14:36 -0500
[...]
Sorry did we understand wrong text of Linux coding style? Or do we need
right interpretation of it?
I'm not engaging in this conversation any more, I don't care what CodingStyle
says, the quoted code is garbage.
This is not really helpful, David.

Andrei's question was fully reasonable here, i.e. the Documentation/CodingStyle is the only binding reference given to potential contributors -- the common 'how-to-contribute-kernel-patches' docs non-24/7-kernel-folks usually find and follow on the way preparing patches end exactly there.

I recently learned the hard way when my patches were ignored just because of some missing spaces. That would be perfectly fair if some formal rules were broken, but not telling people about additional informal ones is not motivating.


I might be fully blind and just missed the related coding style document that covers the issues discussed here. But even then your answer should be 'RTFM' instead of just ending the conversation.


Cheers, Zefir
Thread (21 messages) 21 messages, 9 authors, last reply 2012-02-29
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help