Thread (21 messages) 21 messages, 9 authors, 2012-02-29

RE: [PATCH] checkpatch: Add some --strict coding style checks

From: Joe Perches <joe@perches.com>
Date: 2012-02-21 23:16:16
Also in: lkml, netdev

On Tue, 2012-02-21 at 22:09 +0000, Allan, Bruce W wrote:
This appears to falsely complain about parenthesis alignment in
conditional statements with multiple opening parentheses.  For
example, these will report a check condition:

	if (test_and_set_bit(nr,
				   addr))
		baz();

	if (!(func_a(x) &&
		func_b(y)))
		baz();

Assuming my stupid mailer will screw up the indentation above, the 'a'
in addr in the first example is meant to be immediately below the 'n'
in nr, and the two 'f's in func_* are meant to be vertically lined up
in the second example.
You're right, thanks for testing.
The logic I used is too trivial.

Andrew, please ditch this one for awhile.

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help