Thread (91 messages) flat view 91 messages, 15 authors, 2012-01-03

Re: loading firmware while usermodehelper disabled.

From: Alan Cox <hidden>
Date: 2012-01-02 23:59:51
Also in: lkml

On Mon, 2 Jan 2012 13:27:03 -0800
Linus Torvalds [off-list ref] wrote:
On Mon, Jan 2, 2012 at 1:19 PM, Matthew Garrett [off-list ref] wrote:
quoted
On Mon, Jan 02, 2012 at 12:48:48PM -0800, Linus Torvalds wrote:
quoted
Why are you guys making it any more complicated than that?
Because it's inadequate. You can't guarantee that we ever loaded
firmware.
If we didn't load the firmware before the suspend, then the resume
function of a device sure as hell had better not load it at resume
time either.
Get a clue. It is very common that devices keep firmware over OS warm
boots, particularly if onboard. "Lesser" beings than yourself consider it
a feature of good hardware design for fast booting and it works happily
in "lesser" OS products such Windows.

If you'd like a typical worked example the Fujitsu Q550 has a 3G modem on
it. So in the following cases we don't load firmware at boot but we do
need to after hibernate/resume

Boot windows, reboot to Linux
Boot Linux, reboot to Linux (first loads, second doesn't)

Break that and you have a regression and Linus says regressions are wrong
and we don't do them.
And don't make the stupid argument that we don't know. That's just
inane. Either the driver loads the firmware at startup, or it doesn't.
Wrong.
Fix the 99%. Screw the crazy shit, don't even bother worrying about it
until *after* the 99% is fixed.
This is the 99%. This is PC hardware, the 99% is crazy shit.

Alan
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help