Thread (17 messages) 17 messages, 4 authors, 2011-12-18

Re: [PATCH] mac80211: reset addba retries after timeout

From: Johannes Berg <johannes@sipsolutions.net>
Date: 2011-12-06 09:09:40

On Mon, 2011-12-05 at 22:03 -0500, Nikolay Martynov wrote:
Currently code allows three (HT_AGG_MAX_RETRIES) unanswered addba
requests. When this limit is reached aggregation is turned off for
given TID permanently. This doesn't seem right: three requests is
not that much, some 'blackout' can happen, but effect of it affects
whole connection indefinitely.
  This patch increases number of retries to 15. Also, when there have
been 3 or more retries it splits further retries apart by 15 seconds
instead of sending them in very short period of time.

Signed-off-by: Nikolay Martynov <redacted>
+	if (sta->ampdu_mlme.addba_req_num[tid] > HT_AGG_BURST_RETRIES &&
+	   jiffies - sta->ampdu_mlme.last_addba_req_time[tid] <
+	   HT_AGG_RETRIES_PERIOD) {
You should use the time_after or time_before macros to avoid issues with
jiffies wrapping. Other than that looks good to me.

johannes
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help