Thread (36 messages) 36 messages, 3 authors, 2011-09-15

Re: [PATCH 08/27] iwlagn: beautify the code - remove uneeded line break

From: Joe Perches <joe@perches.com>
Date: 2011-09-15 19:37:50

On Thu, 2011-09-15 at 11:46 -0700, Wey-Yi Guy wrote:
quoted hunk ↗ jump to hunk
From: Emmanuel Grumbach <redacted>
Two lines could be concatenated without exceeding the 80 char limit.
diff --git a/drivers/net/wireless/iwlwifi/iwl-trans.c b/drivers/net/wireless/iwlwifi/iwl-trans.c
[]
quoted hunk ↗ jump to hunk
@@ -308,10 +308,8 @@ static int iwl_trans_txq_alloc(struct iwl_trans *trans,
 
 	txq->q.n_window = slots_num;
 
-	txq->meta = kzalloc(sizeof(txq->meta[0]) * slots_num,
-			    GFP_KERNEL);
-	txq->cmd = kzalloc(sizeof(txq->cmd[0]) * slots_num,
-			   GFP_KERNEL);
+	txq->meta = kzalloc(sizeof(txq->meta[0]) * slots_num, GFP_KERNEL);
+	txq->cmd = kzalloc(sizeof(txq->cmd[0]) * slots_num, GFP_KERNEL);
kcalloc would be even prettier...

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help