Re: [PATCH 08/27] iwlagn: beautify the code - remove uneeded line break

On Thu, 2011-09-15 at 12:37 -0700, Joe Perches wrote:

On Thu, 2011-09-15 at 11:46 -0700, Wey-Yi Guy wrote:

quoted

From: Emmanuel Grumbach <redacted>
Two lines could be concatenated without exceeding the 80 char limit.

diff --git a/drivers/net/wireless/iwlwifi/iwl-trans.c b/drivers/net/wireless/iwlwifi/iwl-trans.c

[]

quoted

@@ -308,10 +308,8 @@ static int iwl_trans_txq_alloc(struct iwl_trans *trans,
 
 	txq->q.n_window = slots_num;
 
-	txq->meta = kzalloc(sizeof(txq->meta[0]) * slots_num,
-			    GFP_KERNEL);
-	txq->cmd = kzalloc(sizeof(txq->cmd[0]) * slots_num,
-			   GFP_KERNEL);
+	txq->meta = kzalloc(sizeof(txq->meta[0]) * slots_num, GFP_KERNEL);
+	txq->cmd = kzalloc(sizeof(txq->cmd[0]) * slots_num, GFP_KERNEL);

kcalloc would be even prettier...

agree, would you mind submit a patch to changes it

Thanks
Wey