Re: [PATCH 05/60] iwlagn: introduce struct iwl-shared - known by all layers
From: Stanislaw Gruszka <hidden>
Date: 2011-08-15 14:23:05
From: Stanislaw Gruszka <hidden>
Date: 2011-08-15 14:23:05
On Mon, Aug 15, 2011 at 06:13:39AM -0700, Guy, Wey-Yi wrote:
now we are working on separate iwlagn driver into two layers (upper and lower), the lower layer contains both bus and transport sub-layer which is hw dependent, and the upper layer should be bus/hw independent. by doing so, the single driver can handle different bus and different core architecture. Having the share data structure (priv->shrd->foo) between two layers is for that reason (loosely couple).
You did not explained reason for introducing iwl_shared structure, actually you confirmed it is useless. You should simply share iwl_priv on any layer you have. Stanislaw