Thread (79 messages) 79 messages, 4 authors, 2011-08-24

RE: [PATCH 05/60] iwlagn: introduce struct iwl-shared - known by all layers

From: Grumbach, Emmanuel <hidden>
Date: 2011-08-16 16:24:55

Hi Stanislaw,

First thank you for the helpful review
Simply by adding to iwl_priv different struct ops/data for each upper
layer you will have. You need to have the same thing to clue with
mac80211, whatever upper layer will be. Otherwise, if mac80211 clue
have to be different, new hardware probably needs different driver.
I would be reluctant to have all the data / ops needed by all the possible HW
all the time in priv. I don't think it is a good idea to have unallocated pointers
for a bus that don't need the rings...
Instead, I think that having a HW specific area that is allocated for each HW is much
nicer and reliable. This is what this patch series is all about.
Furthermore, I don't want the HW layer to dereference iwl_priv, the same way the low level
driver doesn't dereference mac80211's local pointer. This is what the iwl_shared is all about.

Are things clearer now ?
---------------------------------------------------------------------
Intel Israel (74) Limited

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help