Re: [PATCH 4/6] mac80211: update mesh peering frame format

On Mon, 2011-08-08 at 11:47 -0700, Thomas Pedersen wrote:

quoted

quoted

+     case WLAN_CATEGORY_SELF_PROTECTED:
+             switch (mgmt->u.action.u.self_prot.action_code) {
+             case WLAN_SP_MESH_PEERING_OPEN:
+             case WLAN_SP_MESH_PEERING_CLOSE:
+             case WLAN_SP_MESH_PEERING_CONFIRM:
+                     if (!ieee80211_vif_is_mesh(&sdata->vif))
+                             goto invalid;
+                     if (sdata->u.mesh.security != IEEE80211_MESH_SEC_NONE)
+                             /* userspace handles this frame */

Will this compile in the CONFIG_MAC80211_MESH=n case? It seems like it
might not? Do you routinely test that?

Yes. The CONFIG_MAC80211_MESH check around the ieee80211_if_mesh was
removed in c80d545da3f7c0e534ccd4a780f322f80a92cff1

I mean the "sdata->u.mesh.security" dereference. I know vif_is_mesh() is
always available, but I thought u.mesh wasn't?

johannes