Re: [PATCH 4/6] mac80211: update mesh peering frame format
From: Johannes Berg <johannes@sipsolutions.net>
Date: 2011-08-08 13:24:34
On Mon, 2011-07-25 at 16:59 -0700, Thomas Pedersen wrote:
-#define PLINK_GET_LLID(p) (p + 4) -#define PLINK_GET_PLID(p) (p + 6) +#define PLINK_GET_LLID(p) (p + 2) +#define PLINK_GET_PLID(p) (p + 4)
This is a more tangential comment -- but I'd feel more comfortable with the code if these macros were removed and some structs overlaid the IEs instead. But definitely not as part of this patch -- hence tangential.
+ case WLAN_CATEGORY_SELF_PROTECTED:
+ switch (mgmt->u.action.u.self_prot.action_code) {
+ case WLAN_SP_MESH_PEERING_OPEN:
+ case WLAN_SP_MESH_PEERING_CLOSE:
+ case WLAN_SP_MESH_PEERING_CONFIRM:
+ if (!ieee80211_vif_is_mesh(&sdata->vif))
+ goto invalid;
+ if (sdata->u.mesh.security != IEEE80211_MESH_SEC_NONE)
+ /* userspace handles this frame */Will this compile in the CONFIG_MAC80211_MESH=n case? It seems like it might not? Do you routinely test that? johannes