Re: [ath9k-devel] [PATCH net-next 1/2] wireless: Remove casts of void *

On Tuesday 14 June 2011 18:43:51 Joe Perches wrote:

On Tue, 2011-06-14 at 12:31 -0400, Pavel Roskin wrote:

quoted

On 06/14/2011 12:02 AM, Joe Perches wrote:

quoted

  		/* Get the message ID */
-		msg_id = (__be16 *) ((void *) htc_hdr +
-				     sizeof(struct htc_frame_hdr));
+		msg_id = (void *)htc_hdr + sizeof(struct htc_frame_hdr);

I would never do stuff like this without verifying by sparse that no 
warnings are introduced.

I did that.  I believe there are no new warnings.

quoted

Sparse warnings should be avoided to keep sparse checks useful. 
Otherwise, important warnings would drown in the noise.

$ make allyesconfig
$ git log -1 --pretty=oneline drivers/net/wireless/ath/ath9k/htc_hst.c
337c22b774ff7f007b90b266b25c9a33ff555c48 wireless: Remove casts of void *
$ make C=2 drivers/net/wireless/ath/ath9k/htc_hst.o

Just a quick FYI: To perform endianness checks, you may define __CHECK_ENDIAN__:

make C=2 CF="-D__CHECK_ENDIAN__"

[Although, it doesn't look like your patch introduced any new endianness
problems]

Regards,
	Chr