Thread (11 messages) flat view 11 messages, 5 authors, 2011-06-14

Re: [ath9k-devel] [PATCH net-next 1/2] wireless: Remove casts of void *

From: Pavel Roskin <hidden>
Date: 2011-06-14 16:41:29
Also in: lkml, netdev

On 06/14/2011 12:02 AM, Joe Perches wrote:
  		/* Get the message ID */
-		msg_id = (__be16 *) ((void *) htc_hdr +
-				     sizeof(struct htc_frame_hdr));
+		msg_id = (void *)htc_hdr + sizeof(struct htc_frame_hdr);
I would never do stuff like this without verifying by sparse that no 
warnings are introduced.

Sparse warnings should be avoided to keep sparse checks useful. 
Otherwise, important warnings would drown in the noise.

-- 
Regards,
Pavel Roskin
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help