Thread (9 messages) 9 messages, 4 authors, 2011-02-14

Re: Missing skb_pad() return value checks in rt2x00 driver

From: Wolfgang Kufner <hidden>
Date: 2011-02-06 19:37:23

Hi Ivo,

On Sun, Feb 6, 2011 at 5:17 PM, Ivo Van Doorn [off-list ref] wrote:
Between here and where you added the padding are a couple of function
calls which use the skb->len field. So this patch would change the value what
they expect. Have you checked the possible impact?
I don't think skb_pad() touches skb->len. It writes zeros into the tailroom:
/**
*      skb_pad                 -       zero pad the tail of an skb
*      @skb: buffer to pad
*      @pad: space to pad
*
*      Ensure that a buffer is followed by a padding area that is zero
*      filled. Used by network drivers which may DMA or transfer data
*      beyond the buffer end onto the wire.
*
*      May return error in out of memory cases. The skb is freed on error.
*/

Thanks,
Wolfgang
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help