Re: Missing skb_pad() return value checks in rt2x00 driver

Hi,

Well this patch managed to slip through my list. :S

From 4a8b3969775cd233750a1b74b1d4f5fc065932bf Mon Sep 17 00:00:00 2001
From: Seth Forshee <redacted>
Date: Mon, 7 Feb 2011 13:50:33 -0600
Subject: [PATCH] rt2x00: Check for errors from skb_pad() calls

Commit 739fd94 ("rt2x00: Pad beacon to multiple of 32 bits")
added calls to skb_pad() without checking the return value,
which could cause problems if any of those calls does happen
to fail. Add checks to prevent this from happening.

Thanks for the updated patch. I only have one small request.

+       if (padding_len && skb_pad(entry->skb, padding_len)) {
+               dev_err(rt2x00dev->dev, "Failure padding beacon, aborting\n");

Please change to:
  ERROR(rt2x00dev, "Failure padding beacon, aborting\n");
same for the other changed drivers in this patch.

Thanks,

Ivo