Re: [PATCH 3/4] usb: host: ehci-sh: propagate errors from platform_get_irq()
From: Alan Stern <stern@rowland.harvard.edu>
Date: 2021-12-14 21:04:25
On Tue, Dec 14, 2021 at 11:42:46PM +0300, Sergey Shtylyov wrote:
The driver overrides the error codes and IRQ0 returned by platform_get_irq() to -ENODEV. Switch to propagating the error codes upstream. IRQ0 is no longer returned by platform_get_irq(), so we now can safely ignore it... Signed-off-by: Sergey Shtylyov <redacted> ---
Acked-by: Alan Stern <stern@rowland.harvard.edu>
quoted hunk ↗ jump to hunk
drivers/usb/host/ehci-sh.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)diff --git a/drivers/usb/host/ehci-sh.c b/drivers/usb/host/ehci-sh.c index c25c51d26f26..882231b5c382 100644 --- a/drivers/usb/host/ehci-sh.c +++ b/drivers/usb/host/ehci-sh.c@@ -82,8 +82,8 @@ static int ehci_hcd_sh_probe(struct platform_device *pdev) return -ENODEV; irq = platform_get_irq(pdev, 0); - if (irq <= 0) { - ret = -ENODEV; + if (irq < 0) { + ret = irq; goto fail_create_hcd; }-- 2.26.3