Re: [PATCH 2/4] usb: gadget: udc: pxa25x: propagate errors from platform_get_irq()
From: Daniel Mack <daniel@zonque.org>
Date: 2021-12-17 10:40:51
Also in:
linux-arm-kernel
On 12/14/21 21:42, Sergey Shtylyov wrote:
The driver overrides the error codes returned by platform_get_irq() to -ENODEV for some strange reason. Switch to propagating the error codes upstream. Signed-off-by: Sergey Shtylyov <redacted>
Acked-by: Daniel Mack <daniel@zonque.org> Greg, could you take this through your tree? Best, Daniel
quoted hunk ↗ jump to hunk
--- drivers/usb/gadget/udc/pxa25x_udc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/drivers/usb/gadget/udc/pxa25x_udc.c b/drivers/usb/gadget/udc/pxa25x_udc.c index 52cdfd8212d6..b38747fd3bb0 100644 --- a/drivers/usb/gadget/udc/pxa25x_udc.c +++ b/drivers/usb/gadget/udc/pxa25x_udc.c@@ -2364,7 +2364,7 @@ static int pxa25x_udc_probe(struct platform_device *pdev) irq = platform_get_irq(pdev, 0); if (irq < 0) - return -ENODEV; + return irq; dev->regs = devm_platform_ioremap_resource(pdev, 0); if (IS_ERR(dev->regs))