Re: [PATCH 03/22] usb: host: ehci-npcm7xx: deny IRQ0
From: Avi Fishman <avifishman70@gmail.com>
Date: 2021-10-19 07:11:42
Also in:
openbmc
From: Avi Fishman <avifishman70@gmail.com>
Date: 2021-10-19 07:11:42
Also in:
openbmc
On Mon, Oct 18, 2021 at 9:39 PM Sergey Shtylyov [off-list ref] wrote:
If platform_get_irq() returns IRQ0 (considered invalid according to Linus) the driver blithely passes it to usb_add_hcd() that treats IRQ0 as no IRQ at all. Deny IRQ0 right away, returning -EINVAL from the probe() method... Fixes: df44831ee2dd ("USB host: Add USB ehci support for nuvoton npcm7xx platform") Signed-off-by: Sergey Shtylyov <redacted> --- drivers/usb/host/ehci-npcm7xx.c | 4 ++++ 1 file changed, 4 insertions(+)diff --git a/drivers/usb/host/ehci-npcm7xx.c b/drivers/usb/host/ehci-npcm7xx.c index 6b5a7a873e01..aff3d906ced5 100644 --- a/drivers/usb/host/ehci-npcm7xx.c +++ b/drivers/usb/host/ehci-npcm7xx.c@@ -114,6 +114,10 @@ static int npcm7xx_ehci_hcd_drv_probe(struct platform_device *pdev) retval = irq; goto fail; } + if (!irq) { + retval = -EINVAL; + goto fail; + } /* * Right now device-tree probed devices don't get dma_mask set. --2.26.3
Reviewed-by: Avi Fishman <avifishman70@gmail.com> -- Regards, Avi