Thread (41 messages) 41 messages, 8 authors, 2021-10-27
STALE1680d
Revisions (2)
  1. v1 current
  2. v2 [diff vs current]

[PATCH 07/22] usb: host: ehci-st: deny IRQ0

From: Sergey Shtylyov <hidden>
Date: 2021-10-18 18:41:32
Also in: linux-arm-kernel
Subsystem: arm/sti architecture, the rest, usb ehci driver, usb subsystem · Maintainers: Patrice Chotard, Linus Torvalds, Alan Stern, Greg Kroah-Hartman

If platform_get_irq() returns IRQ0 (considered invalid according to Linus)
the driver blithely passes it to usb_add_hcd() that treats IRQ0 as no IRQ
at all. Deny IRQ0 right away, returning -EINVAL from the probe() method...

Fixes: e47c5a0906f9 ("usb: host: ehci-st: Add EHCI support for ST STB devices")
Signed-off-by: Sergey Shtylyov <redacted>
---
 drivers/usb/host/ehci-st.c | 2 ++
 1 file changed, 2 insertions(+)
diff --git a/drivers/usb/host/ehci-st.c b/drivers/usb/host/ehci-st.c
index f74433aac948..5f53c313f943 100644
--- a/drivers/usb/host/ehci-st.c
+++ b/drivers/usb/host/ehci-st.c
@@ -160,6 +160,8 @@ static int st_ehci_platform_probe(struct platform_device *dev)
 	irq = platform_get_irq(dev, 0);
 	if (irq < 0)
 		return irq;
+	if (!irq)
+		return -EINVAL;
 	res_mem = platform_get_resource(dev, IORESOURCE_MEM, 0);
 	if (!res_mem) {
 		dev_err(&dev->dev, "no memory resource provided");
-- 
2.26.3
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help