Re: [PATCH v1] usb: xhci: tegra: Check padctrl interrupt presence in device tree
From: Dmitry Osipenko <digetx@gmail.com>
Date: 2021-10-26 07:23:22
Also in:
linux-tegra, lkml
From: Dmitry Osipenko <digetx@gmail.com>
Date: 2021-10-26 07:23:22
Also in:
linux-tegra, lkml
21.10.2021 17:57, Dmitry Osipenko пишет:
It might be wrong to disable device_may_wakeup() because it will change the system suspend-resume behaviour, i.e. you won't be able to resume by USB event, see [1]. [1] https://elixir.bootlin.com/linux/v5.15-rc6/source/drivers/usb/host/xhci-tegra.c#L1962 Although, I'm not sure whether this is a correct behaviour to start with. Previously, before the offending commit, device_wakeup was never enabled for tegra-xusb. Commit message doesn't explain why wakeup is now enabled unconditionally, wakeup checks aren't needed at all then. This makes no sense, please check it with JC Kuo.
I looked at it again and now see that disabling wakeup actually should restore the old code behaviour properly because previously wakeup wasn't ever enabled. Alright, I'll prepare v2.