Re: [PATCH v1] usb: xhci: tegra: Check padctrl interrupt presence in device tree
From: Michał Mirosław <mirq-linux@rere.qmqm.pl>
Date: 2021-10-21 21:37:42
Also in:
linux-tegra, lkml
On Thu, Oct 21, 2021 at 02:55:01PM +0300, Dmitry Osipenko wrote:
Older device-trees don't specify padctrl interrupt and xhci-tegra driver now fails to probe with -EINVAL using those device-trees. Check interrupt presence and disallow runtime PM suspension if it's missing to fix the trouble.
[...]
quoted hunk ↗ jump to hunk
--- a/drivers/usb/host/xhci-tegra.c +++ b/drivers/usb/host/xhci-tegra.c@@ -1454,10 +1454,13 @@ static int tegra_xusb_probe(struct platform_device *pdev) goto put_padctl; } - tegra->padctl_irq = of_irq_get(np, 0); - if (tegra->padctl_irq <= 0) { - err = (tegra->padctl_irq == 0) ? -ENODEV : tegra->padctl_irq; - goto put_padctl; + /* Older device-trees don't specify padctrl interrupt */ + if (of_property_read_bool(np, "interrupts")) {
Does this catch "interrupts-extended"?
+ tegra->padctl_irq = of_irq_get(np, 0);
+ if (tegra->padctl_irq <= 0) {
+ err = (tegra->padctl_irq == 0) ? -ENODEV : tegra->padctl_irq;
+ goto put_padctl;
+ }Best Regards Michał Mirosław