Re: [PATCH v3 0/2] Stop calling request_irq(), etc. with invalid IRQs in the USB drivers`

On 8/14/21 4:34 PM, Greg Kroah-Hartman wrote:

quoted

quoted

quoted

Here are 2 patches against the 'usb-linus' branch of GregKH's 'usb.git' repo.

Wait, why that branch?

   What branch I'd use for the fixes then?

Ah, you really want this in for 5.14-final?

   Not necessarily, it's your call. But all the patches are fixes.

People are hitting this issue now?

   No, the patches ware all the result of the code reviews...

quoted

quoted

 Please make them against the branch you want
them applied to.  Hopefully they will apply to the usb-next branch...

   I didn't intend them for usb-next but looks like they apply there too.

I think it belongs there as a "nice cleanup to have", right?

   No, they're definitely not cleanups and all have the "Fixes:" tags, so going
to end up in the stable trees (some already have).
   There's going to be 10-patch series soon, all fixing the deferred probing due
to platfrorm_get_irq()...
   Luckily, the USB tree doesn't shave the 3rd kind of platfrorm_get_irq() bugs:
treating 0 as error and returning it immediately along with the negative values,
without doing the remaining part of probe...

thanks,

greg k-h

MBR, Sergey