Thread (9 messages) flat view 9 messages, 4 authors, 2021-08-14

Re: [PATCH v3 2/2] usb: phy: tahvo: add IRQ check

From: Felipe Balbi <balbi@kernel.org>
Date: 2021-08-14 11:28:51

Sergey Shtylyov [off-list ref] writes:
The driver neglects to check the result of platform_get_irq()'s call and
blithely passes the negative error codes to request_threaded_irq() (which
takes *unsigned* IRQ #), causing it to fail with -EINVAL, overriding an
original error code.  Stop calling request_threaded_irq() with the invalid
IRQ #s.

Fixes: 9ba96ae5074c ("usb: omap1: Tahvo USB transceiver driver")
Signed-off-by: Sergey Shtylyov <redacted>
Acked-by: Felipe Balbi <balbi@kernel.org>

-- 
balbi
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help