Thread (13 messages) 13 messages, 4 authors, 2021-08-13

Re: [PATCH 4/9] usb: gadget: udc: s3c2410: add IRQ check

From: Felipe Balbi <balbi@kernel.org>
Date: 2021-08-09 10:11:29
Also in: linux-arm-kernel, linux-samsung-soc

Sergey Shtylyov [off-list ref] writes:
The driver neglects to check the result of platform_get_irq()'s call and
blithely passes the negative error codes to devm_request_irq() (which takes
*unsigned* IRQ #), causing it to fail with -EINVAL, overriding an original
error code. Stop calling devm_request_irq() with the invalid IRQ #s.

Fixes: 8b2e76687b39 ("USB: AT91 UDC updates, mostly power management")
Signed-off-by: Sergey Shtylyov <redacted>
Acked-by: Felipe Balbi <balbi@kernel.org>

-- 
balbi
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help