Thread (13 messages) 13 messages, 4 authors, 2021-08-13

Re: [PATCH 1/9] usb: dwc3: meson-g12a: add IRQ check

From: Felipe Balbi <balbi@kernel.org>
Date: 2021-08-09 10:10:41
Also in: linux-amlogic, linux-arm-kernel

Sergey Shtylyov [off-list ref] writes:
The driver neglects to check the result of platform_get_irq()'s call and
blithely passes the negative error codes to devm_request_threaded_irq()
(which takes *unsigned* IRQ #), causing it to fail with -EINVAL, overriding
an original error code. Stop calling devm_request_threaded_irq() with the
invalid IRQ #s.

Fixes: f90db10779ad ("usb: dwc3: meson-g12a: Add support for IRQ based OTG switching")
Signed-off-by: Sergey Shtylyov <redacted>
Acked-by: Felipe Balbi <balbi@kernel.org>


-- 
balbi
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help